~stoth/saa7164-18271 Changelog

merge http://kernellabs.com/hg/~mkrufky/tda18271

Fri, 02 Oct 2009 14:57:51 -0400

merge http://kernellabs.com/hg/~mkrufky/tda18271

From: Steven Toth

merge http://kernellabs.com/hg/~mkrufky/tda18271

Priority: normal

Signed-off-by: Steven Toth

tda18271: display some state information in debug output

Mon, 28 Sep 2009 02:13:49 -0400

tda18271: display some state information in debug output

From: Michael Krufky

Display i2c adapter id, address and master / slave role in debug output.

Priority: normal

Signed-off-by: Michael Krufky

tda18271: more signedness fixes

Sun, 27 Sep 2009 22:10:20 -0400

tda18271: more signedness fixes

From: Michael Krufky

Convert tda18271_rf_tracking_filter_cal.rf_[ab][12] from int to s32.
Convert tda18271_priv.tm_rfcal from unsigned int to u8.
Cast subtractions between u32 values as s32.

Priority: normal

Signed-off-by: Michael Krufky

tda18271: use temporary variables in tda18271_rf_tracking_filters_init

Sun, 27 Sep 2009 16:00:13 -0400

tda18271: use temporary variables in tda18271_rf_tracking_filters_init

From: Michael Krufky

Use temporary variables for signed calulations between unsigned values

Priority: normal

Signed-off-by: Michael Krufky

tda18271: fix signedness issue in tda18271_rf_tracking_filters_init

Sun, 27 Sep 2009 15:42:29 -0400

tda18271: fix signedness issue in tda18271_rf_tracking_filters_init

From: Seth Barry

While having tda18271 module set with debug=17 (cal & info prints) and
cal=0 (delay calibration process until first use) - I discovered that
during the calibration process, if the frequency test for 69750000
returned a bcal of 0 (see tda18721-fe.c in tda18271_powerscan func) that
the tuner wouldn't be able to pickup any of the frequencies in the range
(all the other frequencies bands returned bcal=1). I spent some time
going over the code and the NXP's tda18271 spec (ver.4 of it i think) and
adding a lot of debug prints and walking/stepping through the calibration
process. I found that when the powerscan fails to find a frequency, the
rf calibration is not run and the default value is supposed to be used in
its place (pulled from the RF_CAL_map table) - but something was getting
goofed up there.

Now, my c coding skills are very rusty, but i think root of the problem is
a signedness issue with the math operation for calculating the rf_a1 and
rf_a2 values in tda18271_rf_tracking_filters_init func, which results in
values like 20648 for rf_a1 (when it should probably have a value like 0,
or so slightly negative that it should be zero - this bad value for rf_a1
would in turn makes the approx calc within
tda18271c2_rf_tracking_filters_correction go out of whack). The simplest
solution i found was to explicitly convert the signedness of the
denominator to avoid the implicit conversion. The values placed into the
u32 rf_freq array should never exceed about 900mhz, so i think the s32 max
value shouldn't be an issue in this case.

I've tested it out a little, and even when i get a bcal=0 with the
modified code, the default calibration value gets used, rf_a1 is zero, and
the tuner seems to lock on the stream and mythtv seems to play it fine.

priority: high

Signed-off-by: Seth Barry
Signed-off-by: Michael Krufky

tda8290: enable deemphasis_50 module parameter

Sun, 27 Sep 2009 17:19:58 -0400

tda8290: enable deemphasis_50 module parameter

From: Henk Vergonet

This adds a forgotten module_param macro needed to set a deemphasis of 50us.
It is the standard setting for commercial FM radio broadcasts outside the US.

Priority: high

Signed-off-by: Henk Vergonet
Signed-off-by: Michael Krufky

tda18271: fix overflow in FM radio frequency calculation

Sun, 27 Sep 2009 13:05:12 -0400

tda18271: fix overflow in FM radio frequency calculation

From: Michael Krufky

Multiplication by 62500 causes an overflow in the 32 bit freq variable,
which is later divided by 1000 when using FM radio.

This patch prevents the overflow by scaling the frequency value correctly
upfront. Thanks to Henk Vergonet for spotting the problem and providing
a preliminary patch, which this changeset was based upon.

Priority: high

Cc: Henk Vergonet
Signed-off-by: Michael Krufky

SAA7164: Removed bus registration messages from driver startup

Thu, 17 Sep 2009 20:00:40 -0400

SAA7164: Removed bus registration messages from driver startup

From: Steven Toth

SAA7164: Removed bus registration messages from driver startup

Priority: normal

Signed-off-by: Steven Toth

SAA7164: Remove the i2c client_attach/detach support, no longer required.

Thu, 17 Sep 2009 14:06:45 -0400

SAA7164: Remove the i2c client_attach/detach support, no longer required.

From: Steven Toth

SAA7164: Remove the i2c client_attach/detach support, no longer required.

Priority: normal

Signed-off-by: Steven Toth

SAA7164: Remove the SAA7164 bus id, no longer required.

Thu, 17 Sep 2009 14:05:38 -0400

SAA7164: Remove the SAA7164 bus id, no longer required.

From: Steven Toth

SAA7164: Remove the SAA7164 bus id, no longer required.

Priority: normal

Signed-off-by: Steven Toth